Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes the code more readable via early returns / fatal errors in guards #35

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Makes the code more readable via early returns / fatal errors in guards #35

merged 1 commit into from
Mar 24, 2017

Conversation

shto
Copy link
Contributor

@shto shto commented Mar 24, 2017

IMO the code reads better with guards instead of the nested if statements

rahul-malik
rahul-malik approved these changes Mar 24, 2017
View reviewed changes
Copy link
Collaborator

@rahul-malik rahul-malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rahul-malik
Copy link
Collaborator

rahul-malik commented Mar 24, 2017 •
edited
Loading

@shto - Thanks for cleaning this up and welcome to the project!

@rahul-malik rahul-malik merged commit 38f6da3 into pinterest:master Mar 24, 2017
@shto
Copy link
Contributor Author

shto commented Mar 24, 2017

👍 You got it, good job on this interesting project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-malik rahul-malik rahul-malik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shto @rahul-malik